Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding phantom disconnectWalletFromDapp and disconnectWalletFromAllDa… #19

Open
wants to merge 1 commit into
base: phantom-support
Choose a base branch
from

Conversation

phantomTony
Copy link

adding phantom disconnectWalletFromDapp and disconnectWalletFromAllDapps

#(issue)
https://linear.app/phantom-labs/issue/ECO-1889/remove-trusted-dapp

Quality checklist

  • I have performed a self-review of my code.

Copy link
Collaborator

@maximgeerinck maximgeerinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you commit everything? I was expecting the selectors to have changed (pages/phantom/main-page.js) cause we don't have all selectors defined in extension and in the pages file

@phantomTony
Copy link
Author

Did you commit everything? I was expecting the selectors to have changed (pages/phantom/main-page.js) cause we don't have all selectors defined in extension and in the pages file

preexisting selectors used:
https://github.com/phantom/synpress/blob/6139bb6a681c9c9dccebc210fbcfccf25da4a95e/pages/phantom/main-page.js#L75
https://github.com/phantom/synpress/blob/6139bb6a681c9c9dccebc210fbcfccf25da4a95e/pages/phantom/main-page.js#L96
https://github.com/phantom/synpress/blob/6139bb6a681c9c9dccebc210fbcfccf25da4a95e/pages/phantom/main-page.js#L98

no new selectors were required

@maximgeerinck
Copy link
Collaborator

account-options-menu__connected-sites

These will have to be verified, we copied the file from metamask (perhaps we shouldn't have done this).
I searched the phantom-wallet repo and couldn't find this selector anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants