Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De gasclustering pipeline #1

Merged
merged 4 commits into from
Dec 10, 2024
Merged

De gasclustering pipeline #1

merged 4 commits into from
Dec 10, 2024

Conversation

sgsutcliffe
Copy link
Collaborator

@sgsutcliffe sgsutcliffe commented Dec 9, 2024

As of now, this is a branch to simply remove what exists from the gasclustering migration to fastmatchirida.

  • Removed 'gasclustering` name from files
  • Remove the section after profile_dist
  • Remove tests that relied on Arborview, and GAS
  • Pass CI
  • Clean up documentation

Copy link

github-actions bot commented Dec 9, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ff3f028

+| ✅ 146 tests passed       |+
#| ❔  28 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-fastmatchirida_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-fastmatchirida_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-fastmatchirida_logo_dark.png
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: lib/Utils.groovy
  • files_exist - File is ignored: lib/WorkflowMain.groovy
  • files_exist - File is ignored: lib/NfcoreTemplate.groovy
  • files_exist - File is ignored: lib/Workflowfastmatchirida.groovy
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • nextflow_config - Config variable ignored: params.max_cpus
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-fastmatchirida_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-fastmatchirida_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-fastmatchirida_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fastmatchirida/fastmatchirida/.github/workflows/awstest.yml
  • actions_awsfulltest - actions_awsfulltest
  • pipeline_name_conventions - pipeline_name_conventions

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.1
  • Run at 2024-12-10 15:30:44

@sgsutcliffe
Copy link
Collaborator Author

@apetkau I'm not going to tackle the documentation yet, so I can get started on the user story. I think the repo is functional enough to get started!

@sgsutcliffe sgsutcliffe requested a review from apetkau December 10, 2024 15:59
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks so much @sgsutcliffe

Note I'm mostly concerned with making sure tests/linting pass in this PR. Fixing up all docs is for later.

@sgsutcliffe sgsutcliffe merged commit cbea074 into dev Dec 10, 2024
4 checks passed
@sgsutcliffe sgsutcliffe deleted the de-gasclustering-pipeline branch December 10, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants