fix: kill dhclient process when interface was dhcp

pfsensible · May 8, 2023 · 9f84c1d · 9f84c1d
1 parent ebfed94
commit 9f84c1d
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/plugins/module_utils/interface.py b/plugins/module_utils/interface.py
@@ -220,9 +220,17 @@ def _copy_and_update_target(self):
         if changed:
             if self.params['enable']:
                 self.setup_interface_cmds += "interface_bring_down('{0}', false);\n".format(self.target_elt.tag)
+
+                # possibly kill remaining dhclient process
+                if 'ipaddr' in before and before['ipaddr'] == 'dhcp':
+                    self.setup_interface_cmds += "kill_dhclient_process(get_real_interface({0}));\n".format(self.target_elt.tag)
+
                 self.setup_interface_cmds += "interface_configure('{0}', true);\n".format(self.target_elt.tag)
             else:
                 self.setup_interface_cmds += "interface_bring_down('{0}', true);\n".format(self.target_elt.tag)
+                # possibly kill remaining dhclient process
+                if 'ipaddr' in before and before['ipaddr'] == 'dhcp':
+                    self.setup_interface_cmds += "kill_dhclient_process(get_real_interface({0}));\n".format(self.target_elt.tag)
 
         return (before, changed)