Skip to content

Commit

Permalink
Fix to include static settings in addition to dynamic repo metadata s…
Browse files Browse the repository at this point in the history
…ettings during s3 plugin reload (opensearch-project#10452)

Signed-off-by: vikasvb90 <[email protected]>
  • Loading branch information
vikasvb90 authored Oct 6, 2023
1 parent e4c477a commit 4fee40d
Showing 1 changed file with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -374,9 +374,8 @@ public void reload(RepositoryMetadata newRepositoryMetadata) {
readRepositoryMetadata();

// Reload configs for S3RepositoryPlugin
final Map<String, S3ClientSettings> clientsSettings = S3ClientSettings.load(metadata.settings(), pluginConfigPath);
service.refreshAndClearCache(clientsSettings);
s3AsyncService.refreshAndClearCache(clientsSettings);
service.settings(metadata);
s3AsyncService.settings(metadata);

// Reload configs for S3BlobStore
BlobStore blobStore = getBlobStore();
Expand Down

0 comments on commit 4fee40d

Please sign in to comment.