Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a.rychkov/contest fixes #24

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Moonko
Copy link

@Moonko Moonko commented Jun 25, 2019

  1. Bug. The message with Markdown tags sent from iOS can be corrupted.

Technical description: There is a mistake in Markdown parsing algorithm. The text from the beginning is pasted between tags. I fixed the mistake.

  1. Bug or improvement. A bug from contest platform. User can't continuously seek the video.

Technical description: First of all, we can't perform seek instantly for performance and traffic sake. So we need to debounce seeking. I found there are 4 types of video nodes and universal one that can play a video item. All of them use the same scrubber view. I've decided to put debounce logic in the scrubber class because it already contains some (It decides not to send seek events on scrub updates). Then, we must pause the video during the seeking until the user lifts his finger. I suppose the video item would be the right place for this logic, not the view.

Remarks:

  1. I've chosen debounce over throttling for seeking because throttling could produce outdated frames which are confusing.
  2. Altough I did the fix, personally I'd prefer to do it way like YouTube does. When user starts seeking, the player shows preview and continues playing. But it requires more time and, highly desirable, backend support for the best UX.
  1. Bug. It's hard to touch the video seek control.

Technical description: Control's touch area height is only 34 points. I extended it.

  1. Bug or improvement. Swipe controls in the iOS app have bad UX.
  • Animation is too fast so its hard to follow. It stands out of the rest of animations.
  • There is no pan selection confirmation for 1 option for non-taptic devices. User can't get the point when he selects the option.
  • When option is selected by long pan, it jiggles a little. Mostly visible with 1 option available.

Technical description: A spring animation causes the option to jiggle unnaturally. I've replaced the animation timing, added icon and text animation for cases then there is only 1 option (like native iOS Mail app). It also affects and fixed multiple options animation.

  1. Bug. Can't close image item (loaded as file) in gallery by swiping it if its not loaded. Also side swipes stop working after user tries to close the file once.

Technical description: I've decided to make document item class subclass of Zoomable item in order to get UIScrollView for closing scroll mechanism to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant