IMPORTANT this branch missing localization, added mute tab bar notification permission warning featured #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation permission warning featured
tar500
reviewed
Jun 24, 2019
| @@ -204,74 +208,78 @@ private enum NotificationsAndSoundsEntry: ItemListNodeEntry { | |||
| return 3 | |||
| case .permissionEnable: | |||
| return 4 | |||
| case .messageHeader: | |||
There was a problem hiding this comment.
This switch statement needs some refactoring :) Otherwise diff is not readable.
There was a problem hiding this comment.
Totally agree, one of solution is to get rid of “= X” and give Swift do Int enumeration automatically base on case position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT localization is missing for this task
Not sure it can be merged (maybe there are a specific reason), but me and a lot of my friends get annoyed when there are a "!" arrow in tab bar when we disable notification in settings with a specific reason.