-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: env management commands #37
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # source/commands/login.tsx # source/lib/api.ts
@35C4n0r the lint has some errors.. |
Hey, some functional comments:
|
Please merge from main |
# Conflicts: # .gitignore # package-lock.json # package.json
Hey, @35C4n0r, the |
@gemanor, pushed a change that fixes the issue, It now handles the case when |
@35C4n0r, the scope is redundnat (just use the default), and the description/strategy should be also in the wizard, not only as variables |
@gemanor done! |
The tests are failing now. Also, the success message is missing from the copy command. |
There are also many linting warning. Please ensure you're fixing the useEffect dependencies problems. Just use the standard practices like useCallback/useMemo and pure functions to avoid such. |
@gemanor fixed the error |
As for the warnings, if I don't want something to be the dependency of a useEffect, why should I add it in the dependency array? |
@gemanor, fixed the warnings |
Closes #18
/claim #18