Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Set of ESLint Rules and remove warnings #21

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

Mubashirshariq
Copy link
Contributor

closes #15
/claim #15

@Mubashirshariq
Copy link
Contributor Author

@gemanor Please let me know if you want any other rules then i will add those also

@Mubashirshariq
Copy link
Contributor Author

Screen.Recording.2024-10-29.at.2.01.59.AM.mov

@Mubashirshariq
Copy link
Contributor Author

@gemanor i have made the requested changes ,plz review

Copy link
Collaborator

@gemanor gemanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please address the attached comments.

package.json Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
source/commands/apiKey.tsx Outdated Show resolved Hide resolved
source/commands/login.tsx Show resolved Hide resolved
@Mubashirshariq
Copy link
Contributor Author

@gemanor , Suggested changes has been implemented. Plz review it.

Screen.Recording.2024-11-20.at.6.52.36.PM.mov

@gemanor gemanor merged commit 9733b53 into permitio:main Nov 20, 2024
0 of 3 checks passed
@Mubashirshariq
Copy link
Contributor Author

@gemanor could you please take a look, bounty for this issue is not released yet.Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Set of ESLint Rules and Clear the Errors/Warning
2 participants