On exit, uperf server to kill child's pid also #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
< try again this PR from the official repo instead of my fork repo just in case the fork repo creates issue for CI>
Sypnopsis: Improve uperf server exit logic for CRR.
Description: On a high scale CRR test, we could see the client fails to connect to the server on the second or later sample runs. The root cause is the server side may have two uperf processes LISTEN on the control port. One process is the "good" one, and the other is actually the left-over from the previous run.
This could happen because the main uperf server process spawns a child, but the current uperf-server-stop only kills the main process. CRR notoriously has issue with not being able to shutdown all connection cleanly. In this case, the child process remains alive and LISTENs to the port, and not die with the parent - On the next run, we end up having two processes listen on the control port.
Fix: Also find and kill the child process on uperf-server-stop.
Test: CRR profile and all other profiles are perfectly happy with the new code