PT-2375 - fixed pt-table-sync for tables with generated columns #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hpoettker
force-pushed
the
PT-2375_table_sync_with_generated_columns
branch
from
5ec39fb
to
a29a293
Compare
|
I updated the PR such that the change is also included in |
hpoettker
force-pushed
the
PT-2375_table_sync_with_generated_columns
branch
2 times, most recently
from
151c22d
to
6549655
Compare
Previously, pt-table-sync generated DML statements that included the generated columns of a table, which is however rejected by the database and not necessary for the required sync statements.
hpoettker
force-pushed
the
PT-2375_table_sync_with_generated_columns
branch
from
6549655
to
5f14441
Compare
|
Thanks so much for the massive effort to adjust the code base to MySQL 8.4! I've rebased the changes on the latest commit in 3.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is intended to resolve this issue: https://perconadev.atlassian.net/browse/PT-2375
The tests added with
pt-2375.tboth fail with the current code base when executing the generated DML statements. With the proposed change, they run successfully. They test that bothREPLACEandUPDATEstatements are generated correctly bypt-table-syncwhen applied to tables with generated columns.The code is my own creation and it can be distributed under the GPL2 licence.