Release 0.9.0 #137
Merged
Release 0.9.0 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
133 tests
133 update improvements
Improvements in returning pephub stats info
nleroy917
reviewed
Jul 2, 2024
| @@ -17,7 +17,7 @@ jobs: | |||
| image: postgres | |||
| env: | |||
| POSTGRES_USER: postgres | |||
| POSTGRES_PASSWORD: docker | |||
| POSTGRES_PASSWORD: pass8743hf9h23f87h437 | |||
There was a problem hiding this comment.
As long as this isnt some secret we use... 👍🏼
Comment on lines
+343
to
+353
| def delete_schema(self, engine=None) -> None: | ||
| """ | ||
| Delete sql schema in the database. | ||
|
|
||
| :param engine: sqlalchemy engine [Default: None] | ||
| :return: None | ||
| """ | ||
| if not engine: | ||
| engine = self._engine | ||
| Base.metadata.drop_all(engine) | ||
| return None |
There was a problem hiding this comment.
For what? Seems like a dangerous function
Comment on lines
+51
to
57
| self._project = PEPDatabaseProject(pep_db_engine) | ||
| self._annotation = PEPDatabaseAnnotation(pep_db_engine) | ||
| self._namespace = PEPDatabaseNamespace(pep_db_engine) | ||
| self._sample = PEPDatabaseSample(pep_db_engine) | ||
| self._user = PEPDatabaseUser(pep_db_engine) | ||
| self._view = PEPDatabaseView(pep_db_engine) | ||
|
|
There was a problem hiding this comment.
👍🏼 I like the look of the double underscore more... but its my understanding you aren't supposed to use double underscores...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: