Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce Slider component with tailwind #1908

Merged
merged 9 commits into from
Nov 18, 2024
Merged

Reintroduce Slider component with tailwind #1908

merged 9 commits into from
Nov 18, 2024

Conversation

JasonMHasperhoven
Copy link
Contributor

@JasonMHasperhoven JasonMHasperhoven commented Nov 15, 2024

Will be part of the order form:

image

Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: 97f8ae4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@penumbra-zone/ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 15, 2024

Visit the preview URL for this PR (updated for commit 97f8ae4):

https://penumbra-ui-preview--pr1908-slider2-m83l56qf.web.app

(expires Fri, 22 Nov 2024 16:36:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

@JasonMHasperhoven JasonMHasperhoven changed the title [WIP] Reintroduce Slider component with tailwind Reintroduce Slider component with tailwind Nov 15, 2024
@JasonMHasperhoven JasonMHasperhoven requested a review from a team November 15, 2024 16:33
Copy link
Contributor

@VanishMax VanishMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the Storybook, the component works nicely.

question: how difficult was it for you personally to switch it to Tailwind?

@JasonMHasperhoven
Copy link
Contributor Author

Checked the Storybook, the component works nicely.

question: how difficult was it for you personally to switch it to Tailwind?

I'm a newb to tailwind, I learned that it doesn't support template strings for classnames so I bumped into this as an issue. Otherwise it's quite easy and straightforward.

@JasonMHasperhoven JasonMHasperhoven merged commit ed23c18 into main Nov 18, 2024
8 checks passed
@JasonMHasperhoven JasonMHasperhoven deleted the slider2 branch November 18, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants