fix(migration): release storage locks #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're seeing an error related to polling the proving keys via the proto package's build.rs. Let's just enable lfs=true on the git checkout action.
|
Non-blocking, but, wouldn't dropping the |
zbuc
approved these changes
May 7, 2024
|
@hdevalence we can't await aborting tasks using RAII, the problem is that releasing resources happens after the handle has been dropped |
cratelyn
added
C-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #4344. Hat tip to @erwanor for spotting the omission.
Issue ticket number and link
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
Testing/review
This change is a bit tricky to test manually, but the rationale in #4344 is sound. I'd like to get it in, so we can rebase #4337 on top of it, and go back to debugging #4340.