Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix platform deployment, upgrade to Python 3.11 #167

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

mureytasroc
Copy link
Contributor

@mureytasroc mureytasroc commented Nov 5, 2023

This PR fixes prod platform deployment by updating our pinned version of black, and upgrading to Python 3.11.

It also fixes tests and aims to get platform CI working / deploying again.

To do this, we bumped the debian version of shibboleth-sp-nginx from 10 (buster) to 12 (bookworm) in this PR.

Copy link

gitguardian bot commented Nov 5, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@mureytasroc
Copy link
Contributor Author

mureytasroc commented Nov 5, 2023

GitGuardian is erroneously flagging the dev secrets in backend/Platform/settings/base.py. These are not prod secrets.

Copy link
Contributor

@joyliu-q joyliu-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (edit: looking back I was naive)

@mureytasroc mureytasroc changed the title Fix platform deployment, upgrade to Python 3.10 Fix platform deployment, upgrade to Python 3.11 Nov 5, 2023
@joyliu-q joyliu-q merged commit 4de6262 into master Nov 5, 2023
7 checks passed
@joyliu-q joyliu-q deleted the fix-platform-deployment branch November 5, 2023 20:44
@mureytasroc mureytasroc restored the fix-platform-deployment branch November 5, 2023 22:39
@mureytasroc
Copy link
Contributor Author

This PR is continued here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants