Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket drop time UI support, unapproved club event visibility changes #750

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

julianweng
Copy link
Member

@julianweng julianweng commented Nov 23, 2024

  • Add UI support for ticket drop times
  • Add ticket_drop_time validation in event serializer based on event end time
  • Prevent retroactive editing of ticket drop time after tickets have been sold (plus handling of edge case where ticket has been added to cart but not bought before ticket drop time is pushed back)
  • Prevent unapproved clubs from selling tickets (add_to_cart)
  • Prevent clubs which have been archived from selling existing tickets
  • Allow leaders of unapproved clubs to create and view events (with the warning that such events are not visible to the public until the club is approved), allowing for "draft" functionality (also currently, the event just disappears after submission on the frontend for unapproved clubs...)
  • Standardize spelling of "publicly" in the codebase (alternative being "publically")
  • Add button to view public event page within event editing page
  • Show all clubs in /directory which have been approved at some point

Event page with unreleased tickets

Unapproved club event (displayed to officers only)

Note for events without a ticket_drop_time

User viewport after clicking on link to ticket_drop_time field within note

…ing details for non-dropped events, add ticket_drop_time serializer validation, make events belonging to unapproved clubs visible to club leaders specifically, standardize spelling of "publicly"
…ged following a ticket being added to a user's cart
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.01%. Comparing base (b280dc0) to head (8d0adca).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
backend/clubs/views.py 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   71.95%   72.01%   +0.05%     
==========================================
  Files          32       32              
  Lines        6953     6967      +14     
==========================================
+ Hits         5003     5017      +14     
  Misses       1950     1950              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support ticket drop times on frontend
1 participant