Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Multivalue TXT Records #193

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Allow Multivalue TXT Records #193

merged 4 commits into from
Mar 4, 2024

Conversation

esinx
Copy link
Member

@esinx esinx commented Mar 2, 2024

Related to DNS Challenges being rejected because certbot cannot add multivalue TXT records to Route 53.

Motivation

Currently, when K8s want to reissue certificates, in order for the certificate request to complete, it must go through an order to complete an acme challenge.

To complete this challenge, it needs to have access to add another TXT record to Route 53. However, doing so when there already exists non-multivalue TXT records leads to the following error:

failed to change Route 53 record set: InvalidChangeBatch: [RRSet with DNS name _acme-challenge.[DOMAIN NAME], 
type TXT, SetIdentifier "(redacted)" cannot be created because a non multivalue answer
rrset exists with the same name and type.[]

Changes

This PR ensures the records created by terraform to Route53 are multivalue records.

@esinx esinx requested a review from joyliu-q March 2, 2024 22:03
Copy link
Contributor

@joyliu-q joyliu-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joyliu-q joyliu-q merged commit 43c3fb2 into master Mar 4, 2024
3 checks passed
@joyliu-q joyliu-q deleted the fix/txt-multivalue branch March 4, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants