Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: error ao processar cash de memoria
higodf
requested changes
Nov 10, 2022
MdWsSeiRest.php
Outdated
| @@ -301,7 +301,9 @@ public function adicionarElementoMenu() | |||
| } | |||
|
|
|||
| $html = $this->montaCorpoHTMLQRCode($nomeArquivo); | |||
| CacheSEI::getInstance()->setAtributo($nomeArquivo, $html, CacheSEI::getInstance()->getNumTempo()); | |||
| try{ | |||
| CacheSEI::getInstance()->setAtributo($nomeArquivo, $html, CacheSEI::getInstance()->getNumTempo()); | |||
There was a problem hiding this comment.
Prezados não podemos aceitar essa correção porque o tratamento de erro não pode apenas esconde-lo, sem ao menos registrar o ocorrido no log do sistema.
A correção esperada é identificar o motivo da falha e corrigir o problema.
There was a problem hiding this comment.
Corrigido em um novo commit
higodf
requested changes
Dec 13, 2022
…-cache-em-memória
|
Feito merge de master! |
higodf
requested changes
Dec 14, 2022
|
O qrcode não aparece mais. Deveria aparecer conforme vídeo. Peek.2023-03-07.10-52-noaudio.mp4 |
|
Refeita a correção em novo PR, https://github.com/supergovbr/super/pull/221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: error ao processar cash de memoria