Changed to new socket interface from network library. #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
==========================================
+ Coverage 64.94% 65.32% +0.37%
==========================================
Files 48 48
Lines 5263 5188 -75
==========================================
- Hits 3418 3389 -29
+ Misses 1845 1799 -46
☔ View full report in Codecov by Sentry. |
davidv1992
force-pushed
the
socket-migration
branch
2 times, most recently
from
de56f4b to
56e67d2
Compare
davidv1992
changed the title
davidv1992
force-pushed
the
socket-migration
branch
2 times, most recently
from
8c0318e to
b127816
Compare
davidv1992
force-pushed
the
socket-migration
branch
from
b127816 to
b6b738c
Compare
folkertdev
reviewed
Oct 5, 2023
| .await | ||
| .unwrap() | ||
| .unwrap_or(local_clock.now()); | ||
| .unwrap(); |
There was a problem hiding this comment.
so a missing timestamp is a panic now? and not even a nice panic but an unwrap on a (from the user) arbitrary line?
There was a problem hiding this comment.
I think this either needs some sort of comment for why unwrapping is OK, or something like an expect or custom panic with more information on what went wrong
There was a problem hiding this comment.
This is dealt with in the follow up pull request.
folkertdev
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.