Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate port for tests to avoid bugs with manual allocation. #1754

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

davidv1992
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 96.70330% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.18%. Comparing base (359bdf8) to head (48e8bef).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
ntpd/src/daemon/keyexchange.rs 93.93% 2 Missing ⚠️
ntpd/src/daemon/spawn/sock.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1754      +/-   ##
==========================================
- Coverage   81.45%   81.18%   -0.27%     
==========================================
  Files          66       66              
  Lines       20508    20153     -355     
==========================================
- Hits        16704    16361     -343     
+ Misses       3804     3792      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnijveld rnijveld added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 7366f2d Dec 11, 2024
20 checks passed
@rnijveld rnijveld deleted the test-port-allocator branch December 11, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants