Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"nts-pool" mode for ntpd client #1241

Merged
merged 4 commits into from
Dec 8, 2023
Merged

"nts-pool" mode for ntpd client #1241

merged 4 commits into from
Dec 8, 2023

Conversation

squell
Copy link
Member

@squell squell commented Nov 30, 2023

This adds a "nts-pool" spawner to the ntpd-rs client. The spawner is closely based on the existing ones for plain NTS and NTP-pool.

This can be reviewed commit-by-commit.

@squell squell force-pushed the nts-pool-client-mode branch from 27a63c6 to ef0981f Compare December 7, 2023 12:46
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 136 lines in your changes are missing coverage. Please review.

Comparison is base (a6fbc9f) 82.85% compared to head (706bd85) 82.29%.

Files Patch % Lines
ntpd/src/daemon/spawn/nts_pool.rs 0.00% 115 Missing ⚠️
ntpd/src/daemon/keyexchange.rs 40.00% 9 Missing ⚠️
ntpd/src/daemon/system.rs 0.00% 7 Missing ⚠️
ntp-proto/src/nts_pool_ke.rs 0.00% 2 Missing ⚠️
ntpd/src/daemon/config/peer.rs 85.71% 2 Missing ⚠️
ntpd/src/daemon/config/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1241      +/-   ##
==========================================
- Coverage   82.85%   82.29%   -0.56%     
==========================================
  Files          65       66       +1     
  Lines       18847    19006     +159     
==========================================
+ Hits        15615    15641      +26     
- Misses       3232     3365     +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@squell squell force-pushed the nts-pool-client-mode branch 3 times, most recently from 45a9ece to 4683870 Compare December 7, 2023 16:18
@squell squell force-pushed the nts-pool-client-mode branch from 4683870 to d497795 Compare December 7, 2023 17:03
@squell squell force-pushed the nts-pool-client-mode branch from d497795 to 706bd85 Compare December 7, 2023 17:22
@squell squell marked this pull request as ready for review December 7, 2023 17:26
ntp-proto/src/nts_record.rs Show resolved Hide resolved
@squell squell added this pull request to the merge queue Dec 8, 2023
Merged via the queue into main with commit 6de1c86 Dec 8, 2023
20 checks passed
@squell squell deleted the nts-pool-client-mode branch December 8, 2023 13:57
@cikzh cikzh added this to the nts-pool milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants