Client pool state machine #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
commented
Nov 26, 2023
folkertdev
force-pushed
the
unrecognized-critical-message
branch
from
0b3884f to
d8f3a3e
Compare
folkertdev
force-pushed
the
client-pool-state-machine
branch
from
9e8c559 to
3a27072
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1230 +/- ##
==========================================
- Coverage 84.63% 82.85% -1.79%
==========================================
Files 64 65 +1
Lines 18446 18847 +401
==========================================
+ Hits 15612 15615 +3
- Misses 2834 3232 +398 ☔ View full report in Codecov by Sentry. |
squell
force-pushed
the
client-pool-state-machine
branch
from
3a27072 to
ae74b60
Compare
squell
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Of course the pool-related stuff should be hidden behind feauture flags.
I think (for maintainability) that it is better if the NTS-POOL-KE related decoders are spun off in their own file (nts_record_extensions.rs or nts_pool_record.rs or some such?). That would also cut down on the amount of #[cfg(feature = "nts-pool")] that is needed.
The changes that are not related to the pool-ke look pretty innocuous to me.
folkertdev
added
waiting for review
and removed
feedback wanted
squell
reviewed
Dec 7, 2023
folkertdev
force-pushed
the
client-pool-state-machine
branch
from
febc345 to
76786f3
Compare
squell
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.