-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement resp INCR command #62
Open
hderms
wants to merge
20
commits into
pelikan-io:main
Choose a base branch
from
hderms:resp_incr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hderms
commented
Feb 7, 2023
hderms
commented
Feb 7, 2023
hderms
commented
Feb 7, 2023
brayniac
reviewed
Feb 8, 2023
brayniac
reviewed
Feb 8, 2023
brayniac
reviewed
Feb 8, 2023
brayniac
requested changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See feedback in-line.
@brayniac did you have any outstanding changes you wanted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
checked_mul
andchecked_add
available to Rust. It's slightly slower than the stdlibstring::parse<i64>()
at this point, but works from a&[u8]
and respects Redis parsing rules, so is preferable for this use caseINCR
SET
RESP command now eagerly checks whether the input value can be parsed as an i64, and if so, stores it as one. Otherwise it stores bytes (current behavior)Notes:
checked_add
with the SegcacheValue
and determining whether it would overflow if we viewed the underlying u64 as an i64 and added to it. If it would not overflow, we simply update the underlying u64 usingwrapping_add
which would be guaranteed not to overflow provided nothing happens in between the check and set, which should be true currently. Adding i64 support to Segcache is probably desirable, but if storage is currently single-threaded, then the current implementation should work