feat: adds PING support to momento proxy resp impl #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brayniac
requested changes
Dec 30, 2022
| @@ -0,0 +1,59 @@ | |||
| // Licensed under the Apache License, Version 2.0 | |||
There was a problem hiding this comment.
let's add the Pelikan Foundation LLC as the copyright holder w/ 2022 year.
| @@ -0,0 +1,22 @@ | |||
| // Licensed under the Apache License, Version 2.0 | |||
| use session::{SESSION_SEND, SESSION_SEND_BYTE, SESSION_SEND_EX}; | ||
| use tokio::io::AsyncWriteExt; | ||
|
|
||
| const PONG_RSP: &[u8; 7] = b"+PONG\r\n"; |
There was a problem hiding this comment.
Is there a reason this wasn't implemented in the RESP protocol instead?
| const PONG_RSP: &[u8; 7] = b"+PONG\r\n"; | ||
|
|
||
| pub async fn ping(socket: &mut tokio::net::TcpStream) -> Result<(), Error> { | ||
| let mut response_buf = Vec::new(); |
There was a problem hiding this comment.
I think you can do all this w/o allocating here
| let mut response_buf = Vec::new(); | ||
| response_buf.extend_from_slice(PONG_RSP); | ||
| SESSION_SEND.increment(); | ||
| SESSION_SEND_BYTE.add(response_buf.len() as _); |
There was a problem hiding this comment.
PONG_RSP.len() should work too?
| SESSION_SEND.increment(); | ||
| SESSION_SEND_BYTE.add(response_buf.len() as _); | ||
| TCP_SEND_BYTE.add(response_buf.len() as _); | ||
| if let Err(e) = socket.write_all(&response_buf).await { |
There was a problem hiding this comment.
i think you could .write_all(PONG_RSP) here?
|
Overall, this works. I think it'd be cleaner for the pong response to be part of the RESP protocol implementation, as that will be useful when we add a redis compatible backend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.