-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
address cargo audit errors and warnings #120
Conversation
Addresses all of the cargo audit errors and warnings by updating dependencies. Removes public export of clocksource types from the common lib and moves to directly depending on clocksource where necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved modulo the one comment about clocksource::referesh_clock
@@ -16,7 +16,6 @@ pub static ADMIN_CONN_CLOSE: Counter = Counter::new(); | |||
|
|||
pub(crate) async fn admin(mut log_drain: Box<dyn logger::Drain>, admin_listener: TcpListener) { | |||
loop { | |||
clocksource::refresh_clock(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure: is this no longer necessary with the new version of clocksource?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. We no longer have any API that returns a "recent" (cached) time.
Addresses all of the cargo audit errors and warnings by updating dependencies.
Removes public export of clocksource types from the common lib and moves to directly depending on clocksource where necessary.