Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address cargo audit errors and warnings #120

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

brayniac
Copy link
Collaborator

@brayniac brayniac commented Jan 23, 2024

Addresses all of the cargo audit errors and warnings by updating dependencies.

Removes public export of clocksource types from the common lib and moves to directly depending on clocksource where necessary.

Addresses all of the cargo audit errors and warnings by updating
dependencies.

Removes public export of clocksource types from the common lib and
moves to directly depending on clocksource where necessary.
@brayniac brayniac changed the title address most cargo audit errors and warnings address cargo audit errors and warnings Jan 23, 2024
@brayniac brayniac requested a review from swlynch99 January 23, 2024 21:59
Copy link
Contributor

@swlynch99 swlynch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved modulo the one comment about clocksource::referesh_clock

@@ -16,7 +16,6 @@ pub static ADMIN_CONN_CLOSE: Counter = Counter::new();

pub(crate) async fn admin(mut log_drain: Box<dyn logger::Drain>, admin_listener: TcpListener) {
loop {
clocksource::refresh_clock();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure: is this no longer necessary with the new version of clocksource?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. We no longer have any API that returns a "recent" (cached) time.

@brayniac brayniac merged commit f2f936b into pelikan-io:main Jan 24, 2024
20 checks passed
@brayniac brayniac deleted the audit branch January 24, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants