CI updates: Modern Node.js versions, action version updates, standard(-ish) template #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just keeps us up to date and avoids warnings for deprecated Node.js versions in CI.
We were all over the place with these, with some going all the way back to Ubuntu 16! Connects pelias/pelias#951
This also rewrites our CI config so that all Node.js versions are on one line for ease of future grepping pelias/pelias#950
orangejulius
deleted the
nodejs-18-and-ci-updates-with-workflow-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a bunch of commits made by a script that standardizes as much as possible our CI config across all repositories.
First and foremost, it ensures we test all Node.js versions that are an LTS release, not EOL, and currently work with this repository.
Also, the CI OS version is now hardcoded to ubuntu-22.04. We fooled around with an organization wide CI variable to configure that, but it broke CI in forks and doesn't really help us much, so it's now undone.
The
pbf2jsonrepo is a bit of a special snowflake because it requires Go to be installed. While other repos could just us an exact copy of a standard template, I've manually updated the Actions workflows here to be as similar as possible: they're split into pull request and push workflows that share a common unit test file. But that common file does the Go install as needed. I updated thesetup-goaction tov5, since internally that updates its own Node.js version, avoiding warnings during CI.Note: The
v5setup-go action seems fairly new, and I noticed this concerning issue report. Doesn't seem to affect us yet, or could be user error, but we should keep an eye out.Connects pelias/pelias#950
Connects pelias/pelias#951