Merge pull request kubernetes#73990 from xichengliudui/fixlinterror

Fix golint failures pkg/kubelet/util/cache
pegasas · Feb 15, 2019 · bf20886 · bf20886
2 parents 60943a7 + 4c42d54
commit bf20886
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/hack/.golint_failures b/hack/.golint_failures
@@ -225,7 +225,6 @@ pkg/kubelet/status/testing
 pkg/kubelet/sysctl
 pkg/kubelet/types
 pkg/kubelet/util
-pkg/kubelet/util/cache
 pkg/kubelet/util/pluginwatcher
 pkg/kubelet/util/queue
 pkg/kubelet/util/sliceutils

diff --git a/pkg/kubelet/util/cache/object_cache.go b/pkg/kubelet/util/cache/object_cache.go
@@ -75,6 +75,7 @@ func (c *ObjectCache) Get(key string) (interface{}, error) {
 	return value.(objectEntry).obj, nil
 }
 
+// Add adds objectEntry by using a unique string as the key.
 func (c *ObjectCache) Add(key string, obj interface{}) error {
 	err := c.cache.Add(objectEntry{key: key, obj: obj})
 	if err != nil {

diff --git a/pkg/kubelet/util/cache/object_cache_test.go b/pkg/kubelet/util/cache/object_cache_test.go
@@ -46,7 +46,7 @@ func TestAddAndGet(t *testing.T) {
 		val: "bar",
 	}
 	objectCache := NewFakeObjectCache(func() (interface{}, error) {
-		return nil, fmt.Errorf("Unexpected Error: updater should never be called in this test!")
+		return nil, fmt.Errorf("Unexpected Error: updater should never be called in this test")
 	}, 1*time.Hour, clock.NewFakeClock(time.Now()))
 
 	err := objectCache.Add(testObj.key, testObj.val)