Skip to content

Commit

Permalink
Remove an old compatibility check/warning
Browse files Browse the repository at this point in the history
It was IPv4-specific but nobody ever noticed this or reported the lack
of IPv6 check as a problem, suggesting that it is no longer needed.
  • Loading branch information
danwinship committed Sep 21, 2023
1 parent 1e862b0 commit b489beb
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions pkg/proxy/iptables/proxier.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ const (
)

const sysctlRouteLocalnet = "net/ipv4/conf/all/route_localnet"
const sysctlBridgeCallIPTables = "net/bridge/bridge-nf-call-iptables"
const sysctlNFConntrackTCPBeLiberal = "net/netfilter/nf_conntrack_tcp_be_liberal"

// internal struct for string service information
Expand Down Expand Up @@ -254,12 +253,6 @@ func NewProxier(ipFamily v1.IPFamily,
conntrackTCPLiberal = true
klog.InfoS("nf_conntrack_tcp_be_liberal set, not installing DROP rules for INVALID packets")
}
// Proxy needs br_netfilter and bridge-nf-call-iptables=1 when containers
// are connected to a Linux bridge (but not SDN bridges). Until most
// plugins handle this, log when config is missing
if val, err := sysctl.GetSysctl(sysctlBridgeCallIPTables); err == nil && val != 1 {
klog.InfoS("Missing br-netfilter module or unset sysctl br-nf-call-iptables, proxy may not work as intended")
}

// Generate the masquerade mark to use for SNAT rules.
masqueradeValue := 1 << uint(masqueradeBit)
Expand Down

0 comments on commit b489beb

Please sign in to comment.