Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing temperature range in special mode "8 degrees" #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implementing temperature range in special mode "8 degrees" #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78dc059
Implementing temperature range in special mode "8 degrees"
ThePMO Dec 1, 2024
a50d4ee
Changed setup to have full temperature range and set special mode dep…
ThePMO Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"githubPullRequests.ignoredPullRequestBranches": [
"main"
]
}
51 changes: 45 additions & 6 deletions components/toshiba_suzumi/toshiba_climate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,10 @@ void ToshibaClimateUart::parseResponse(std::vector<uint8_t> rawData) {
switch (sensor) {
case ToshibaCommandType::TARGET_TEMP:
ESP_LOGI(TAG, "Received target temp: %d", value);
if (this->special_mode_ == SPECIAL_MODE::EIGHT_DEG) {
value -= SPECIAL_TEMP_OFFSET;
ESP_LOGI(TAG, "Note: Special Mode \"%s\" is active, shifting target temp to %d", SPECIAL_MODE_EIGHT_DEG, value);
}
this->target_temperature = value;
break;
case ToshibaCommandType::FAN: {
Expand Down Expand Up @@ -284,12 +288,14 @@ void ToshibaClimateUart::parseResponse(std::vector<uint8_t> rawData) {
this->power_state_ = climateState;
break;
}
case ToshibaCommandType::SPECIAL_MODE: {
auto special_mode = IntToSpecialMode(static_cast<SPECIAL_MODE>(value));
case ToshibaCommandType::SPECIAL_MODE: {
this->special_mode_ = static_cast<SPECIAL_MODE>(value);
auto special_mode = IntToSpecialMode(this->special_mode_.value());
ESP_LOGI(TAG, "Received special mode: %d", value);
if (special_mode_select_ != nullptr) {
special_mode_select_->publish_state(special_mode);
}
this->publish_state();
break;
}
default:
Expand Down Expand Up @@ -348,7 +354,28 @@ void ToshibaClimateUart::control(const climate::ClimateCall &call) {
if (call.get_target_temperature().has_value()) {
auto target_temp = *call.get_target_temperature();
uint8_t intTemp = (uint8_t) target_temp;
bool special_mode_changed = false;
if (intTemp >= this->min_temp_ && this->special_mode_ == SPECIAL_MODE::EIGHT_DEG) {
this->special_mode_ = SPECIAL_MODE::STANDARD;
special_mode_changed = true;
ESP_LOGD(TAG, "Changing to Standard Mode");
}
else if (intTemp < this->min_temp_ && this->special_mode_ != SPECIAL_MODE::EIGHT_DEG)
{
this->special_mode_ = SPECIAL_MODE::EIGHT_DEG;
special_mode_changed = true;
ESP_LOGD(TAG, "Changing to FrostGuard Mode");
}
if (special_mode_changed) {
this->sendCmd(ToshibaCommandType::SPECIAL_MODE, static_cast<uint8_t>(this->special_mode_.value()));
special_mode_select_->publish_state(IntToSpecialMode(this->special_mode_.value()));
}

ESP_LOGD(TAG, "Setting target temp to %d", intTemp);
if (this->special_mode_ == SPECIAL_MODE::EIGHT_DEG) {
intTemp += SPECIAL_TEMP_OFFSET;
ESP_LOGD(TAG, "Note: Special Mode \"%s\" active, shifting setpoint temp to %d", SPECIAL_MODE_EIGHT_DEG, intTemp);
}
this->target_temperature = target_temp;
this->sendCmd(ToshibaCommandType::TARGET_TEMP, intTemp);
}
Expand Down Expand Up @@ -408,9 +435,10 @@ ClimateTraits ToshibaClimateUart::traits() {
traits.add_supported_custom_fan_mode(CUSTOM_FAN_LEVEL_4);
traits.add_supported_custom_fan_mode(CUSTOM_FAN_LEVEL_5);

traits.set_visual_temperature_step(1);
traits.set_visual_min_temperature(this->min_temp_);
traits.set_visual_temperature_step(1);
traits.set_visual_min_temperature(SPECIAL_MODE_EIGHT_DEG_MIN_TEMP);
traits.set_visual_max_temperature(MAX_TEMP);

return traits;
}

Expand All @@ -422,10 +450,21 @@ void ToshibaClimateUart::on_set_pwr_level(const std::string &value) {
}

void ToshibaClimateUart::on_set_special_mode(const std::string &value) {
auto new_special_mode = SpecialModeToInt(value);
ESP_LOGD(TAG, "Setting special mode to %s", value.c_str());
auto special_mode = SpecialModeToInt(value);
this->sendCmd(ToshibaCommandType::SPECIAL_MODE, static_cast<uint8_t>(special_mode.value()));
this->sendCmd(ToshibaCommandType::SPECIAL_MODE, static_cast<uint8_t>(new_special_mode.value()));
special_mode_select_->publish_state(value);
if (new_special_mode != this->special_mode_) {
if (this->special_mode_ == SPECIAL_MODE::EIGHT_DEG && this->target_temperature < this->min_temp_) {
this->target_temperature = NORMAL_MODE_DEF_TEMP;
}
this->special_mode_ = new_special_mode;
if (new_special_mode == SPECIAL_MODE::EIGHT_DEG && this->target_temperature >= this->min_temp_) {
this->target_temperature = SPECIAL_MODE_EIGHT_DEG_DEF_TEMP;
}

this->publish_state();
}
}

void ToshibaPwrModeSelect::control(const std::string &value) { parent_->on_set_pwr_level(value); }
Expand Down
6 changes: 6 additions & 0 deletions components/toshiba_suzumi/toshiba_climate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ namespace toshiba_suzumi {

static const char *const TAG = "ToshibaClimateUart";
static const uint8_t MAX_TEMP = 30;
static const uint8_t SPECIAL_TEMP_OFFSET = 16;
static const uint8_t SPECIAL_MODE_EIGHT_DEG_MIN_TEMP = 5;
static const uint8_t SPECIAL_MODE_EIGHT_DEG_MAX_TEMP = 13;
static const uint8_t SPECIAL_MODE_EIGHT_DEG_DEF_TEMP = 8;
static const uint8_t NORMAL_MODE_DEF_TEMP = 20;

static const std::vector<uint8_t> HANDSHAKE[6] = {
{2, 255, 255, 0, 0, 0, 0, 2}, {2, 255, 255, 1, 0, 0, 1, 2, 254}, {2, 0, 0, 0, 0, 0, 2, 2, 2, 250},
Expand Down Expand Up @@ -58,6 +63,7 @@ class ToshibaClimateUart : public PollingComponent, public climate::Climate, pub
uint32_t last_command_timestamp_ = 0;
uint32_t last_rx_char_timestamp_ = 0;
STATE power_state_ = STATE::OFF;
optional<SPECIAL_MODE> special_mode_ = SPECIAL_MODE::STANDARD;
select::Select *pwr_select_ = nullptr;
sensor::Sensor *outdoor_temp_sensor_ = nullptr;
bool horizontal_swing_ = false;
Expand Down