Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cases when SDK config file is blank #171

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lib/goth/config.ex
Original file line number Diff line number Diff line change
Expand Up @@ -232,13 +232,14 @@ defmodule Goth.Config do
end

def get_configuration_data(configuration_file) do
if File.regular?(configuration_file) do
configuration_data = configuration_file |> File.read!() |> decode_ini()

# Only retrieve the required data.
%{"project_id" => configuration_data["core"]["project"], "actor_email" => configuration_data["core"]["account"]}
with true <- File.regular?(configuration_file),
configuration_data <- configuration_file |> File.read!() |> decode_ini(),
project_id when not is_nil(project_id) <- configuration_data["core"]["project"],
actor_email when not is_nil(actor_email) <- configuration_data["core"]["account"] do
%{"project_id" => project_id, "actor_email" => actor_email}
else
nil
_ ->
nil
end
end

Expand Down
Empty file.
24 changes: 24 additions & 0 deletions test/goth/config_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,30 @@ defmodule Goth.ConfigTest do
Application.start(:goth)
end

test "Reading blank configuration should return nil" do
current_json = Application.get_env(:goth, :json)
Application.put_env(:goth, :json, nil, persistent: true)

current_config_root = Application.get_env(:goth, :config_root_dir)

config_root = Path.expand("test/data/home/gcloud")
Application.put_env(:goth, :config_root_dir, config_root)

Application.stop(:goth)
Application.start(:goth)

data =
Path.expand("test/data/home/gcloud/configurations/blank_config_default")
|> Config.get_configuration_data()

assert(data == nil)

Application.put_env(:goth, :config_root_dir, current_config_root, persistent: true)
Application.put_env(:goth, :json, current_json, persistent: true)
Application.stop(:goth)
Application.start(:goth)
end

test "GOOGLE_APPLICATION_CREDENTIALS is read" do
# The test configuration sets an example JSON blob. We override it briefly
# during this test.
Expand Down