Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require php >= 7.4 instead of >7.4 #32

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Require php >= 7.4 instead of >7.4 #32

merged 1 commit into from
Feb 7, 2024

Conversation

demeritcowboy
Copy link
Contributor

Hi,
I'm wondering if this was an oversight to require >7.4 instead of >=7.4 since we see a composer conflict where we have the minimum set to 7.4.0

jparise
jparise approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@jparise jparise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this expression was incorrect. 7.4 is supported as the minimum version, per package.xml.

Thanks for reporting and fixing this!

@jparise jparise merged commit 5f6e365 into pear:master Feb 7, 2024
5 checks passed
@jparise
Copy link
Member

jparise commented Feb 7, 2024

I'll plan on tagging a new release tomorrow.

@demeritcowboy
Copy link
Contributor Author

Thanks!

@demeritcowboy demeritcowboy deleted the php-require branch February 7, 2024 05:37
@demeritcowboy demeritcowboy mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparise jparise jparise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demeritcowboy @jparise