Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove strftime (deprecated in php 8.1) #25

Merged
merged 5 commits into from
Jan 7, 2024
Merged

Remove strftime (deprecated in php 8.1) #25

merged 5 commits into from
Jan 7, 2024

Conversation

sveneld
Copy link
Contributor

@sveneld sveneld commented Jan 7, 2024

Add possibility to configure timeFormatter

@sveneld sveneld mentioned this pull request Jan 7, 2024
Closed
jparise
jparise reviewed Jan 7, 2024
View reviewed changes
Copy link
Member

@jparise jparise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks!

In addition to the comments I left, the docs/guide.txt documentation will also need a few updates.

Log.php Outdated Show resolved Hide resolved
Log.php Show resolved Hide resolved
Log.php Outdated Show resolved Hide resolved
Log.php Outdated Show resolved Hide resolved
Log.php Outdated Show resolved Hide resolved
@sveneld
Copy link
Contributor Author

sveneld commented Jan 7, 2024

modified pull request by your suggestion

jparise
jparise reviewed Jan 7, 2024
View reviewed changes
Copy link
Member

@jparise jparise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also nice to have a unit test for the new formatting behavior (primarily the format converter).

Log.php Outdated Show resolved Hide resolved
Log.php Outdated Show resolved Hide resolved
Log.php Outdated Show resolved Hide resolved
Log.php Outdated Show resolved Hide resolved
docs/guide.txt Outdated Show resolved Hide resolved
@sveneld sveneld force-pushed the strftime branch 5 times, most recently from ccd004b to 21d2f58 Compare January 7, 2024 20:37
@sveneld
Copy link
Contributor Author

sveneld commented Jan 7, 2024

Add some tests

jparise
jparise approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@jparise jparise left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Will merge after the conflicts from #24 are resolved.

sveneld added 4 commits January 7, 2024 21:55
@sveneld
Remove strftime (deprecated in php 8.1)
74107f1 
Add possibility to configure timeFormatter
@sveneld
Remove strftime (deprecated in php 8.1)
524a61c 
Add possibility to configure timeFormatter
@sveneld
Remove strftime (deprecated in php 8.1)
759e60e 
Add possibility to configure timeFormatter
@sveneld
Remove strftime (deprecated in php 8.1)
df20646 
Add possibility to configure timeFormatter
add test
@sveneld
Remove strftime (deprecated in php 8.1)
997fdae 
Add possibility to configure timeFormatter
@sveneld
Copy link
Contributor Author

sveneld commented Jan 7, 2024

Done

@jparise jparise merged commit 99e96b0 into pear:master Jan 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparise jparise jparise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sveneld @jparise