Add missing dependencies for typing-extensions and pysocks #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typing-extensions is strictly required for the script to run, while pysocks is more of an optional dependency. I think pysocks is worth including, since I can't be the only person who accesses cambridge core through a VPN provided by their academic institution.
|
Could you please explain what this commit achieves? I am not exactly sure what you mean by
since I am not using type annotations in this project and the required Python version is 3.10 anyways. Additionally, I do not quite understand why PySocks needs to be added to the requirements if it is not used in the code. I would be happy if you could clarify that a bit. |
pcdi
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typing-extensions is strictly required for the script to run, while pysocks is more of an optional dependency. I think pysocks is worth including, since I can't be the only person who accesses cambridge core through a VPN provided by their academic institution.