♻️ Use getBlockTimestamp() for block.timestamp in vm.warp
#294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
pcaversaccio
added
dependencies 🔁
pcaversaccio
changed the title
getBlockTimestamp() instead of block.timestamp if vm.warpgetBlockTimestamp() for block.timestamp in vm.warp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🕓 Changelog
This PR refactors
TimelockController.t.solto usegetBlockTimestamp()instead ofblock.timestamp, asblock.timestampis assumed to be constant across a transaction and will be optimised out by the compiler. For more details, see issue. Additionally,solhinthas been upgraded to the latest version,v5.0.4, and all submodules have been updated to their most recent commits.🐶 Cute Animal Picture