Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Enforce PEP 8 Code Style Conventions #287

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

pcaversaccio
Copy link
Owner

@pcaversaccio pcaversaccio commented Nov 6, 2024

πŸ•“ Changelog

This PR implements the PEP 8 – Style Guide for Python Code across all 🐍 snekmate contracts. In addition, it incorporates the following opinionated set of rules:

  • Each line of code should be limited to a maximum of 120 characters, including spaces.
  • Code comments should be confined to a maximum of 80 characters per line, including spaces, with an allowed exception for comments with long URL links.

Furthermore, the evaluation order of the if-else statements in the multicall contract has been reversed, changing from if (batch.allow_failure == False): to if batch.allow_failure:. Please note that the gas snapshot changes stem from a recent update to the OpenZeppelin library submodule, introduced by this commit.

🐢 Cute Animal Picture

Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio pcaversaccio self-assigned this Nov 6, 2024
@pcaversaccio pcaversaccio added documentation πŸ“– Improvements or additions to documentation dependencies πŸ” Pull requests that update a dependency file refactor/cleanup ♻️ Code refactorings and cleanups labels Nov 6, 2024
@pcaversaccio pcaversaccio added this to the 0.1.1 milestone Nov 6, 2024
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio pcaversaccio merged commit 5a3e9f0 into main Nov 6, 2024
15 checks passed
@pcaversaccio pcaversaccio deleted the style/pythonic-formatting branch November 6, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies πŸ” Pull requests that update a dependency file documentation πŸ“– Improvements or additions to documentation refactor/cleanup ♻️ Code refactorings and cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant