Skip to content

Commit

Permalink
Merge branch 'main' into modules
Browse files Browse the repository at this point in the history
  • Loading branch information
pcaversaccio authored Mar 18, 2024
2 parents ba6b53c + bc63370 commit dbaabe3
Show file tree
Hide file tree
Showing 9 changed files with 23 additions and 32 deletions.
2 changes: 1 addition & 1 deletion lib/create-util
2 changes: 1 addition & 1 deletion lib/forge-std
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@
"merkletreejs": "^0.3.11",
"prettier": "^3.2.5",
"prettier-plugin-solidity": "^1.3.1",
"solhint": "^4.1.1"
"solhint": "^4.5.2"
}
}
33 changes: 12 additions & 21 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions test/governance/mocks/CallReceiverMock.sol
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,15 @@ contract CallReceiverMock {
* @dev Reverts with an empty reason.
*/
function mockFunctionRevertsWithEmptyReason() public payable {
// solhint-disable-next-line reason-string, custom-errors
// solhint-disable-next-line reason-string, gas-custom-errors
revert();
}

/**
* @dev Reverts with a non-empty reason.
*/
function mockFunctionRevertsWithReason() public payable {
// solhint-disable-next-line custom-errors
// solhint-disable-next-line gas-custom-errors
revert("CallReceiverMock: reverting");
}

Expand Down
4 changes: 2 additions & 2 deletions test/tokens/mocks/ERC1155ReceiverMock.sol
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ contract ERC1155ReceiverMock is ERC165, IERC1155Receiver {
uint256 amount,
bytes memory data
) external returns (bytes4) {
// solhint-disable-next-line reason-string, custom-errors
// solhint-disable-next-line reason-string, gas-custom-errors
require(!recReverts, "ERC1155ReceiverMock: reverting on receive");
emit Received(operator, from, id, amount, data);
return recRetval;
Expand All @@ -92,7 +92,7 @@ contract ERC1155ReceiverMock is ERC165, IERC1155Receiver {
uint256[] memory amounts,
bytes memory data
) external returns (bytes4) {
// solhint-disable-next-line reason-string, custom-errors
// solhint-disable-next-line reason-string, gas-custom-errors
require(!batReverts, "ERC1155ReceiverMock: reverting on batch receive");
emit BatchReceived(operator, from, ids, amounts, data);
return batRetval;
Expand Down
4 changes: 2 additions & 2 deletions test/tokens/mocks/ERC721ReceiverMock.sol
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ contract ERC721ReceiverMock is IERC721Receiver {
bytes memory data
) public override returns (bytes4) {
if (_ERROR == Error.RevertWithMessage) {
// solhint-disable-next-line custom-errors
// solhint-disable-next-line gas-custom-errors
revert("ERC721ReceiverMock: reverting");
} else if (_ERROR == Error.RevertWithoutMessage) {
// solhint-disable-next-line reason-string, custom-errors
// solhint-disable-next-line reason-string, gas-custom-errors
revert();
} else if (_ERROR == Error.Panic) {
uint256 a = uint256(0) / uint256(0);
Expand Down

0 comments on commit dbaabe3

Please sign in to comment.