Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Fix assume Condition in testFuzz_ShouldBeAFunctionOfMultipleBlockPropertiesAndTheCaller #92

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

pcaversaccio
Copy link
Owner

@pcaversaccio pcaversaccio commented Mar 13, 2024

🕓 Changelog

The fuzzing parameter msgSender in testFuzz_ShouldBeAFunctionOfMultipleBlockPropertiesAndTheCaller must not equal SELF (i.e. address(this), the test contract) for the following negative assertion to always hold:

vm.startPrank(msgSender);
assertNotEq(originalSalt, createXHarness.exposed_generateSalt(), "1100");
vm.stopPrank();

🐶 Cute Animal Picture

image

@pcaversaccio pcaversaccio self-assigned this Mar 13, 2024
@pcaversaccio pcaversaccio added the refactor/cleanup ♻️ Code refactorings and cleanups label Mar 13, 2024
@pcaversaccio pcaversaccio added this to the 1.0.0 milestone Mar 13, 2024
@pcaversaccio pcaversaccio requested a review from mds1 March 13, 2024 18:23
Copy link

Coverage after merging fix-generateSalt-test into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   CreateX.sol100%100%100%100%

@pcaversaccio pcaversaccio enabled auto-merge (squash) March 13, 2024 19:08
@pcaversaccio pcaversaccio changed the title ♻️ Fix assume Condition in CreateX_GenerateSalt_Internal_Test ♻️ Fix assume Condition in testFuzz_ShouldBeAFunctionOfMultipleBlockPropertiesAndTheCaller Mar 13, 2024
@pcaversaccio pcaversaccio disabled auto-merge March 13, 2024 19:10
@pcaversaccio pcaversaccio enabled auto-merge (squash) March 13, 2024 19:10
@pcaversaccio
Copy link
Owner Author

Merging since I will add DOS deployment today and I want a clean CI :)

@pcaversaccio pcaversaccio disabled auto-merge March 14, 2024 09:54
@pcaversaccio pcaversaccio merged commit ef6b0d2 into main Mar 14, 2024
14 checks passed
@pcaversaccio pcaversaccio deleted the fix-generateSalt-test branch March 14, 2024 09:54
Copy link
Collaborator

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't approve since it's already merged, but LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor/cleanup ♻️ Code refactorings and cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants