Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add Note on salt-Based Address Calculations #141

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

pcaversaccio
Copy link
Owner

@pcaversaccio pcaversaccio commented Oct 7, 2024

🕓 Changelog

Add clarification on what salt value to use for the read-only functions computeCreate2Address(bytes32,bytes32) and computeCreate3Address(bytes32) (resolves #140).

🐶 Cute Animal Picture

image

Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio pcaversaccio self-assigned this Oct 7, 2024
@pcaversaccio pcaversaccio added the documentation 📖 Improvements or additions to documentation label Oct 7, 2024
@pcaversaccio pcaversaccio added this to the 1.0.0 milestone Oct 7, 2024
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Signed-off-by: Pascal Marco Caversaccio <[email protected]>
@pcaversaccio pcaversaccio changed the title 📖 Add Note on Address Calculation 📖 Add Note on salt-Based Address Calculations Oct 7, 2024
@pcaversaccio pcaversaccio merged commit e9b9b89 into main Oct 7, 2024
10 of 13 checks passed
@pcaversaccio pcaversaccio deleted the docs/create2-deployment-address-calculation branch October 7, 2024 12:36
Copy link

github-actions bot commented Oct 7, 2024

`CreateX` Test Coverage Report

Coverage after merging docs/create2-deployment-address-calculation into main will be
100.00%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   CreateX.sol100%100%100%100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💥 How to Compute the CREATE2 Deployment Address?
1 participant