fix double breaks in WebVtt writer and bump version to 2.2.12.dev8

pbs · Sep 10, 2024 · ad3d54b · ad3d54b
1 parent 64ead7e
commit ad3d54b
Show file tree

Hide file tree

Showing 4 changed files with 121 additions and 130 deletions.
diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -10,6 +10,7 @@ Changelog
 - Ignore repositioning commands which are not followed by any text before breaks.
 - Mid-row codes will not add the space if is in front of punctuation.
 - Fix a bug with background codes when InstructionNodeCreator collection is empty.
+- Fix a bug WebVTT writer adding double line breaks.
 
 2.2.12
 ^^^^^^

diff --git a/pycaption/scc/state_machines.py b/pycaption/scc/state_machines.py
@@ -40,11 +40,10 @@ def update_positioning(self, positioning):
             col = self._last_column
         new_row, new_col = positioning
         is_tab_offset = new_row == row and col + 1 <= new_col <= col + 3
-
         # One line below will be treated as line break, not repositioning
         if new_row == row + 1:
-            self._positions.append((new_row, col))
-            self._break_required = 1
+            self._positions.append((new_row, new_col))
+            self._break_required = True
             self._last_column = new_col
         # Tab offsets after line breaks will be ignored to avoid repositioning
         elif self._break_required and is_tab_offset: