set the correct URL for the next autodiscovery image #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benklop I have dont have as much interest in developing the add-on and I want to focus on the integration. I have done some work previously, and am hosting a repo mostly dedicated to just the script. Lets chat over discord, (and if anyone else is interested. Per RTL_433 the goal of the project is to produce raw output, things like Intergrations are merely suggestions to build on. Let me know if we can connect, https://discord.gg/FFdJMPeP |
|
Wow, nice digging! I double checked as well against the Actions logs and this should be good. Thank you! |
|
I think for this to actually be fixed we'll have to roll a release, or at least merge to the main branch. |
|
Looks like this is going to fail until #165 is fixed. |
This reverts commit 5e56f63.
…-next-autodiscovery
deviantintegral
approved these changes
Oct 27, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The path to the 'next' version of the rtl_433_mqtt_autodiscovery add-on is incorrect, and so when trying to install home assistant actually installs a copy of the main / release version instead. The path should contain 'next-' from what I can tell based on the container names.
Alternatives Considered
I've created my own copy of the repo to work on another feature, and discovered this in the meantime. I can use my own copy of the image there only by making this change.
Testing Steps