Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cice5 restart pointers #535

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix cice5 restart pointers #535

merged 1 commit into from
Oct 25, 2024

Conversation

anton-seaice
Copy link
Contributor

Closes #534

For CICE4 with AUSCOM set, restart pointer file contains:

./iced.xxxx

for CICE5, restart pointer file contains

./RESTART/iced.xxxx

@anton-seaice anton-seaice requested a review from blimlim October 25, 2024 03:01
@pep8speaks
Copy link

Hello @anton-seaice! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 55:80: E501 line too long (80 > 79 characters)
Line 56:51: E203 whitespace before ':'

@coveralls
Copy link

Coverage Status

coverage: 58.549% (+0.2%) from 58.361%
when pulling 85b6665 on cice_restart_ptr
into 74be036 on master.

Copy link
Collaborator

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for the informative issue for the context.

@blimlim
Copy link
Contributor

blimlim commented Oct 25, 2024

Changes look good to me!

Slightly unrelated question, but would there be any value in splitting off a separate cice4 driver? I feel like we keep having to make changes for cice4 in the cice.py driver, and then have to override them in the cice5.py driver, and other times try to fix something for cice5, and then override it for cice4 in the access.py driver. I often get confused jumping between the three different parts trying to work out what's actually going on, so am interested to hear everyone else's opinions!

@anton-seaice anton-seaice merged commit 27aac37 into master Oct 25, 2024
8 checks passed
@anton-seaice anton-seaice deleted the cice_restart_ptr branch October 25, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CICE4 & CICE5 Restart Pointer Files
5 participants