feat(next): pass through query params from document view to find operations #10343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsfletch
reviewed
Jan 6, 2025
| @@ -31,6 +40,11 @@ export const getDocumentData = async ({ | |||
| fallbackLocale: false, | |||
| locale: locale?.code, | |||
| overrideAccess: false, | |||
| req: { | |||
There was a problem hiding this comment.
Feels odd to construct a new req object here instead of passing it through outright. I imagine this is to reduce the size of the actual request as much as possible. Pretty sure you wouldn't have to send user as a stand-alone property in this case.
There was a problem hiding this comment.
imagine this is to reduce the size of the actual request as much as possible
Doesn't matter since this all runs on the server anyways.
I mainly wanted to avoid the overhead of spreading req in order to remove/isolate the transactionID
|
🚀 This is included in version v3.15.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say you opened
http://localhost:3000/admin/collections/posts/67786e917283ec71ce4ab058?branch=main, thebranch=mainquery param would not be passed to the find operation.This means that reading
req.queryin, say, anafterReadhook, you would get an empty object back.This PR threads through
query,searchandsearchParamswith the main goal of making them accessible in hooks.Use-case
Custom branch selector component in a collection's edit view.
Select branch =>
branchquery param is added to the URL.Collection
afterReadhook then fetches the respective content from that branch (which it gets fromreq.query) and returns its data