fix(storage-vercel-blob): return 404 when file is not found #10327
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one 👍 I've released canary versions for testing: |
Thanks, works as expected 👍 |
denolfe
approved these changes
Jan 3, 2025
|
Good work on this one, @andershermansen , thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The vercel storage adapter returns a 500 internal server error when a file is not found.
It's expected that it will return 404 when a file is not found.
Why
The
headfunction from vercel blob sdk does not return undefined when a blob is not found, but throws an error as documented here: https://vercel.com/docs/storage/vercel-blob/using-blob-sdk#headHow
Check if exception thrown is of type BlobNotFoundError and return a 404 in that case.
Testing
Note: I have not been able to test this inside payload itself as I'm unable to build a package to test with. I have tested the implementation outside. Is it possible to get a canary build so proper testing with package can be done?
Fixes #10326