feat(payload-cloud): set up cron jobs on init #10106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
jmikrut
reviewed
Dec 20, 2024
jmikrut
reviewed
Dec 20, 2024
jmikrut
reviewed
Dec 20, 2024
denolfe
reviewed
Dec 20, 2024
| const DEFAULT_CRON_JOB = { | ||
| cron: DEFAULT_CRON, | ||
| limit: DEFAULT_LIMIT, | ||
| queue: 'default (every minute)', |
There was a problem hiding this comment.
Any specific reason we want to put every minute on the end here? What if they change the cron to no longer be every minute and this stays?
There was a problem hiding this comment.
This only ends up in the DB if the user does not define any cronJob. See line 142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has tasks configured, we set up cron jobs on init.
We also make sure to only run on one instance using a instance identifier stored in a global.
This adds a new property to the payloadCloudPlugin:
jobs.