-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
カードフォームの追加属性項目(メール・電話番号)をサポートする #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatatsu
changed the title
[WIP] extra attributes support
カードフォームの追加属性項目(メール・電話番号)をサポートする
Sep 8, 2024
yatatsu
force-pushed
the
feature/extra-attributes-support
branch
from
September 8, 2024 20:47
6be30c1
to
a8402d6
Compare
natsuki-yamanaka
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
カードフォームにメールアドレス・電話番号の項目を追加
iOS・AndroidのSDKをそれぞれ 2.0.0 に更新し、カードフォームの追加属性項目 を表示できるようにしました。
Payjp.startCardForm
に引数extraAttributes
が追加され、追加属性の項目の設定ができるようになります。デフォルトではメールアドレスと電話番号いずれも項目を表示し、いずれかの入力が必須となります。
await Payjp.startCardForm( onCardFormCanceledCallback: _onCardFormCanceled, onCardFormCompletedCallback: _onCardFormCompleted, onCardFormProducedTokenCallback: _onCardFormProducedToken, cardFormType: CardFormType.multiLine, + extraAttributes: [ExtraAttributeEmail(), ExtraAttributePhone()] );
各種依存とサンプルコードの更新
Androidのサポートバージョンの更新
FlutterではAndroid 21以下をサポートしてないため、本ライブラリのサポートも終了しました。
minSdkVersion を 21 に更新しています。
https://docs.flutter.dev/reference/supported-platforms
iOS で CardIO ライブラリの暗黙的な依存の廃止