Change meter event to use the customer's processor ID #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doh, I wasn't paying attention to that either. Thanks for catching that. |
excid3
reviewed
Sep 12, 2024
ayushn21
force-pushed
the
fix-meter-event
branch
2 times, most recently
from
2975a6b to
ed21d5a
Compare
ayushn21
force-pushed
the
fix-meter-event
branch
from
ed21d5a to
ccd56ab
Compare
|
Thanks @ayushn21 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary:
Following on from #1051 (comment), I didn't realise that the
processor_idin the subscription is the ID for the subscription itself rather than the customer. The API requires the ID to be the customer's rather than the subscription's. Stripe throws an error as it stands.As such I've moved the method into the
Customerclass as I feel it belongs there.Checklist: