Add rate limit #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biokrylov
reviewed
Oct 29, 2024
| ] | ||
|
|
||
| async function main() { | ||
| ValidateEnvironmentVariables(initializerArgs) | ||
| ValidateEnvironmentVariables(TOKEN_ADDRESS, ETH_ENDPOINT_CONTRACT_ADDRESS, DELEGATE_ADDRESS, DESTINATION_EID, LIMIT, WINDOW ) |
There was a problem hiding this comment.
why switch from initializerArgs to explicit list?
is it because of the rateLimitConfig object in the array?
I'd suggest to add logic to ValidateEnvironmentVariables in introspect objects and ensure their members are non-null. That way the lists of args to be verified and used will not go out of sync.
wdyt?
There was a problem hiding this comment.
Yes it's because of the rateLimitConfig object. We can add that logic to ValidateEnvironmentVariables , but for now we should just keep it since this is the code that has been audited by Zellic.
biokrylov
approved these changes
Oct 29, 2024
jacobmtorres
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: