Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit paginator when previous token matches current #722

Merged
merged 6 commits into from
Dec 20, 2023

Conversation

DyfanJones
Copy link
Member

This addresses issue: #721

Developed from aws sdk js v3 solution: https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.78.0

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1de2019) 85.30% compared to head (4b54eea) 85.33%.

❗ Current head 4b54eea differs from pull request most recent head 496faaa. Consider uploading reports for the commit 496faaa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
+ Coverage   85.30%   85.33%   +0.03%     
==========================================
  Files         204      204              
  Lines       14662    14692      +30     
==========================================
+ Hits        12507    12537      +30     
  Misses       2155     2155              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DyfanJones
Copy link
Member Author

/style

@DyfanJones DyfanJones merged commit a2eda71 into paws-r:main Dec 20, 2023
@DyfanJones DyfanJones deleted the paginator_empty_result branch January 4, 2024 11:49
@DyfanJones DyfanJones added the enhancement 💡 New feature or request label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💡 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant