-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Show images stored alongside *.md sections #43
Conversation
Not fully sure how zola's internals interact with this, but as of 733f1c1 I'll see image urls built like: |
The trailing slash issue seems to be long running, though it's behaving as expected. There's also a chance that shortcodes are broken or that I'm missing something important about how they work. |
I'm testing a version of my site with @ipetkov, are you using |
Yeah I see the issue with both |
Strange-- I'm on |
@goingforbrooke sure! Here's the source which builds this broken version of the site Here is an example of the broken URLs and this is the corresponding shortcode which generates it Here is what the non-broken version looks like |
Thanks! I haven't run it locally yet, but at first blush, you might be missing a trailing slash in your I'm going off my blog's I'll try adding a slash to the end of my site's |
Doesn't seem to help :/ It adds a redundant (through harmless) slash in some places. The broken image urls are slightly less broken, though now they end up pointing to the root of the domain but not nested under the blog content 🤔 |
Zole might not like the dates that you're prefixing to your blog post directories. For example, your blog post I would suggest that you remove the date prefixes from your blog posts, but What do you think, @ipetkov? |
Zola automatically handles stripping dates from pages (or it's documented as a "feature" at least) because all the other links still work I did a quick test with the various properties that zola's pages are available in the templates:
Seems like |
Thanks for going the extra mile to post output and for trying out different properties! Sadly, using ipetkov.github.io (dates in post titles, subdir style)✅
✅
❌
❌
My Blog (no dates in post titles, top-level style)❌ ❌ ❌
✅
SummaryI'd like to use |
I found the docs on removing dates from slugs. As an aside, why are you defining post dates in the frontmatter of |
SolutionLet's use the We can preserve the look of existing sites by setting the resize dimensions for fit large enough (5000x5000), that no resizing actually happens. This feels unnecessarily hacky, but it provides a stable fix for both posting styles. Research@ipetkov, never mind about the docs reference on date stripping-- I found it. I looked into the docs a bit more and my interpretation is that As for @ipetkov's We want to use The trouble is getting I don't think that there's a built-in way to strip dates from output paths/URLs. We could manually remove dates in the |
Incorporated changes into (new) PR #46. |
No description provided.