Updated default cache policy and performance tweaks

paultopher · Dec 6, 2011 · 26e3c9b · 26e3c9b
1 parent 65c9fcd
commit 26e3c9b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/MKNetworkKit/MKNetworkKit.h b/MKNetworkKit/MKNetworkKit.h
@@ -65,6 +65,7 @@
 #define MKNETWORKCACHE_DEFAULT_COST 10
 #define MKNETWORKCACHE_DEFAULT_DIRECTORY @"MKNetworkKitCache"
 #define kMKNetworkKitDefaultCacheDuration 60 // 1 minute
+#define kMKNetworkKitDefaultImageHeadRequestDuration 3600*24*1 // 1 day (HEAD requests with eTag are sent only after expiry of this. Not that these are not RFC compliant, but needed for performance tuning)
 #define kMKNetworkKitDefaultImageCacheDuration 3600*24*7 // 1 day
 #endif
 

diff --git a/MKNetworkKit/MKNetworkOperation.m b/MKNetworkKit/MKNetworkOperation.m
@@ -433,8 +433,12 @@ - (id)initWithURLString:(NSString *)aURLString
             finalURL = [NSURL URLWithString:aURLString];
         }
 
+        // if your server takes longer than 30 seconds to provide real data,
+        // you should hire a better server developer.
+        // on iOS (or any mobile device), 30 seconds is already considered high.
+
         self.request = [NSMutableURLRequest requestWithURL:finalURL                                                           
-                                               cachePolicy:NSURLRequestReloadIgnoringLocalAndRemoteCacheData                                            
+                                               cachePolicy:NSURLRequestUseProtocolCachePolicy                                            
                                            timeoutInterval:30.0f];
 
         [self.request setHTTPMethod:method];
@@ -813,7 +817,9 @@ - (void)connection:(NSURLConnection *)connection didReceiveResponse:(NSURLRespon
 
             // For images let's assume a expiry date of 7 days if there is no eTag or Last Modified.
             if(!eTag && !lastModified)
-                expiresOnDate = [[NSDate date] dateByAddingTimeInterval:kMKNetworkKitDefaultImageCacheDuration];            
+                expiresOnDate = [[NSDate date] dateByAddingTimeInterval:kMKNetworkKitDefaultImageCacheDuration];
+            else    
+                expiresOnDate = [[NSDate date] dateByAddingTimeInterval:kMKNetworkKitDefaultImageHeadRequestDuration];
         }
 
         for(NSString *substring in cacheControlEntities) {