-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign unknown inputs #85
Sign unknown inputs #85
Conversation
tests are failin |
@paulmillr pls can you check again? |
I guess this superseeds it? https://github.com/paulmillr/scure-btc-signer/releases/tag/1.3.0 |
I don't think the v.1.3.0 release implements this feature, as I don't see it making use of the |
It is exactly what it does, but for taproot only. You can now add script parser (see micro-ordinals), which will have finalizeTaproot for your custom script |
My use case is a |
Why should it follow your code and not some other logic? It can work in "any" way if i'm not mistaken |
Well, then there must be a way to support the redeeming witness creation based on the signature , public key and potentially other data. If the Bitcoin scripting language allows for arbitrary locking script creation, then shouldn't the library here also support arbitrary unlocking script creation? If that's not so easy to implement at this stage, then the best attempt to unlock seems to be placing the signature and public key in front of the script. |
When the script type is unknown the current version of the library does not try to sign the input. In this PR the input is signed by placing the signature and public key in the input script. This is the best attempt to sign. If the input is segwit then the signature will be placed in the final witness, and if it is P2SH the signature will be placed in the sigscript.